Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Put Matplotlib imports inside TimeSeries methods #3376

Merged
merged 2 commits into from
Oct 12, 2019
Merged

Put Matplotlib imports inside TimeSeries methods #3376

merged 2 commits into from
Oct 12, 2019

Conversation

dstansby
Copy link
Member

Fixes #3254

@dstansby dstansby added the timeseries Affects the timeseries submodule label Sep 30, 2019
@dstansby dstansby requested a review from a team September 30, 2019 13:02
@ghost
Copy link

ghost commented Sep 30, 2019 •
edited by ghost
Loading

Thanks for the pull request @dstansby! Everything looks great!

@hayesla
Copy link
Member

hayesla commented Oct 2, 2019

I think just a changelog is needed 👍

@sunpy sunpy deleted a comment Oct 2, 2019
@Cadair Cadair added this to the 1.1 milestone Oct 2, 2019
Cadair
Cadair requested changes Oct 2, 2019
View reviewed changes
Copy link
Member

@Cadair Cadair left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While I am generally in favour of this, I would like us to reach a more comprehensive decision on import policy in other places in SunPy before we do this.

I suggest we discuss more in #3254

@Cadair Cadair added the Merge When CI Passes Hit that merge button when it's all green! label Oct 12, 2019
@Cadair Cadair merged commit ec1346e into sunpy:master Oct 12, 2019
@dstansby dstansby mentioned this pull request Oct 12, 2019
Open
@dstansby dstansby deleted the mpl-import branch October 12, 2019 15:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hayesla hayesla hayesla approved these changes

@Cadair Cadair Cadair approved these changes

Assignees
No one assigned
Labels
Merge When CI Passes Hit that merge button when it's all green! timeseries Affects the timeseries submodule
Projects
None yet
Milestone
1.1
Development

Successfully merging this pull request may close these issues.

Import matplotlib only in plot methods
3 participants
@dstansby @hayesla @Cadair