Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix the manifest file to include the right helpers things and docs #3423

Merged
merged 2 commits into from
Oct 22, 2019
Merged

Fix the manifest file to include the right helpers things and docs #3423

merged 2 commits into from
Oct 22, 2019

Conversation

Cadair
Copy link
Member

@Cadair Cadair commented Oct 22, 2019

@ghost
Copy link

ghost commented Oct 22, 2019 •
edited by ghost
Loading

Thanks for the pull request @Cadair! Everything looks great!

@Cadair Cadair requested a review from nabobalis October 22, 2019 13:01
@Cadair Cadair added this to the 1.0.5 milestone Oct 22, 2019
@nabobalis
Copy link
Contributor

Need to update the template too.

nabobalis
nabobalis reviewed Oct 22, 2019
View reviewed changes
MANIFEST.in Show resolved Hide resolved
@nabobalis
Copy link
Contributor

The template repo is actually ok but since riot is broken again I cant tell anyone that.

@Cadair
Copy link
Member Author

Cadair commented Oct 22, 2019

🤦‍♂️ come on matrix.org sort it out.

@Cadair
Copy link
Member Author

Cadair commented Oct 22, 2019

Wait, if the template is ok, how did NDCube end up in trouble.

@nabobalis
Copy link
Contributor

Wait, if the template is ok, how did NDCube end up in trouble.

A great question to which i have no idea.

@Cadair Cadair added [BugFix] Affects Release An issue/bug that affects a released version (use a version label too) Infrastructure Issues or PRs that affect the CI or packaging. Priority High Rapid action required. labels Oct 22, 2019
@Cadair Cadair merged commit 43c4195 into sunpy:master Oct 22, 2019
@Cadair Cadair modified the milestones: 1.0.5, 1.1 Oct 22, 2019
@backporting backporting bot mentioned this pull request Oct 22, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nabobalis nabobalis nabobalis approved these changes

Assignees
No one assigned
Labels
Affects Release An issue/bug that affects a released version (use a version label too) Infrastructure Issues or PRs that affect the CI or packaging. Priority High Rapid action required.
Projects
None yet
Milestone
1.1
Development

Successfully merging this pull request may close these issues.
2 participants
@Cadair @nabobalis