Make Map work with WISPR Data #3501

Cadair · 2019-11-13T17:02:58Z

Fixes #3496

This makes the following changes:

Change GenericMap.wcs to use the raw FITS header, this is so we can get the extra parameters from the FITS headers for the unusual projections in WISPR data. This is a large change in approach, although I am reasonably confident it shouldn't break anything.
Fix IRIS so that the above change dosen't completely destroy it.
Fix some parfive incompatibility issues in vso.py

requires #3497 to actually make WISPR data load.

ghost · 2019-11-13T17:03:03Z

Thanks for the pull request @Cadair! Everything looks great!

pep8speaks · 2019-11-13T17:03:03Z

Hello @Cadair! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

In the file sunpy/io/fits.py:

Line 205:101: E501 line too long (108 > 100 characters)

In the file sunpy/map/mapbase.py:

Line 271:9: E303 too many blank lines (2)

In the file sunpy/map/tests/test_mapbase.py:

Line 103:101: E501 line too long (110 > 100 characters)

Comment last updated at 2019-11-21 21:52:08 UTC

sunpy/map/sources/iris.py

wafels · 2019-11-13T18:01:56Z

This

https://github.com/sunpy/sunpy/blob/master/sunpy/map/tests/test_mapbase.py#L101

looks off. Should this be

assert all(wcs.wcs.cdelt == [aia171_test_map.scale.axis1.value, aia171_test_map.scale.axis2.value])

?

nabobalis · 2019-11-16T13:08:20Z

I think before we can merge this:

Add WISPR test file
Create tests to make sure we can open it
Fix the tests

WRONG

nabobalis · 2019-11-16T15:49:33Z

This

https://github.com/sunpy/sunpy/blob/master/sunpy/map/tests/test_mapbase.py#L101

looks off. Should this be

assert all(wcs.wcs.cdelt == [aia171_test_map.scale.axis1.value, aia171_test_map.scale.axis2.value])

?

Changed it.

sunpy/map/mapbase.py

sunpy/map/sources/rhessi.py

nabobalis · 2019-11-21T18:47:14Z

sunpy/io/fits.py

-                for hist in hists:
-                    fits_header.add_history(hist)
-            elif k != '':
+        if len(k) > 8:


nabobalis · 2019-11-21T18:47:56Z

sunpy/io/fits.py

        else:
+            # For some horrific reason, we save a list to the wavelnth key in
+            # sources/rhessi.py. This is the least invasive fix for that stupidity.


sunpy/io/fits.py

sunpy/io/tests/test_fits.py

sunpy/net/vso/vso.py

sunpy/io/fits.py

sunpy/io/tests/test_fits.py

changelog/3501.feature.rst

Cadair force-pushed the fix_wispr branch from e99e0b3 to 64eb4a6 Compare November 13, 2019 17:06

Cadair mentioned this pull request Nov 13, 2019

Do not assume the type of header entries #3497

Merged

Cadair commented Nov 13, 2019

View reviewed changes

sunpy/map/sources/iris.py Outdated Show resolved Hide resolved

Cadair added this to the 1.1 milestone Nov 13, 2019

Cadair mentioned this pull request Nov 16, 2019

PSP WISPR data doesn't work out of the box with SunPy #3496

Closed

nabobalis force-pushed the fix_wispr branch from 63c8aca to 9b6f614 Compare November 16, 2019 13:08

nabobalis previously approved these changes Nov 16, 2019

View reviewed changes

nabobalis force-pushed the fix_wispr branch 2 times, most recently from dcc7aef to 60f0ed5 Compare November 16, 2019 15:02

dstansby reviewed Nov 19, 2019

View reviewed changes

sunpy/map/mapbase.py Outdated Show resolved Hide resolved

Cadair self-assigned this Nov 20, 2019

Cadair and others added 8 commits November 21, 2019 15:42

Construct the WCS from the fits header

f555b8b

Fix IRIS so that it has a valid FITS header

b30bd15

Fix darkest VSO errors found while trying to query too much WISPR data

5d2b31d

cleanup

4718056

changelog

84f2ff7

test change

c175c32

if agrees with comment

029752f

Improve the wcs test to allow different units

865f707

Cadair force-pushed the fix_wispr branch from 60f0ed5 to 13088d2 Compare November 21, 2019 17:16

nabobalis approved these changes Nov 21, 2019

View reviewed changes

Fix EIT data with a third WCS dimension?!

33c0144

Cadair force-pushed the fix_wispr branch from 13088d2 to 33c0144 Compare November 21, 2019 17:18

Cadair added 2 commits November 21, 2019 17:21

Elaborate on the FITS header parsing changes

4f7cc8f

update WCS not meta

3952242

Cadair commented Nov 21, 2019

View reviewed changes

sunpy/map/sources/rhessi.py Outdated Show resolved Hide resolved

Please no lists in fits headers

23fb1f6

Cadair force-pushed the fix_wispr branch from 6519d19 to 23fb1f6 Compare November 21, 2019 18:06

Even more work on making our fits_header property be better

eb7924e

Cadair requested review from a team and nabobalis November 21, 2019 18:44

nabobalis reviewed Nov 21, 2019

View reviewed changes

nabobalis approved these changes Nov 21, 2019

View reviewed changes

Add a test for header_to_fits with most of our test data

747b7a7

Cadair requested review from a team and removed request for a team November 21, 2019 20:39

dstansby approved these changes Nov 21, 2019

View reviewed changes

sunpy/io/fits.py Show resolved Hide resolved

sunpy/io/tests/test_fits.py Show resolved Hide resolved

sunpy/net/vso/vso.py Show resolved Hide resolved

Cadair commented Nov 21, 2019

View reviewed changes

sunpy/io/fits.py Show resolved Hide resolved

Cadair commented Nov 21, 2019

View reviewed changes

sunpy/io/tests/test_fits.py Show resolved Hide resolved

Apply suggestions from code review

250d16f

dstansby approved these changes Nov 21, 2019

View reviewed changes

Cadair commented Nov 21, 2019

View reviewed changes

changelog/3501.feature.rst Outdated Show resolved Hide resolved

Update changelog/3501.feature.rst

2b43662

Cadair merged commit 56eef12 into sunpy:master Nov 21, 2019

Cadair deleted the fix_wispr branch November 21, 2019 22:20

This was referenced Nov 22, 2019

Illegal value when saving Map object #3536

Closed

What's New in 1.1 #3553

Closed

dstansby mentioned this pull request Oct 7, 2021

No more modify meta #5501

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Make Map work with WISPR Data #3501

Make Map work with WISPR Data #3501

Cadair commented Nov 13, 2019 •

edited

Loading

ghost commented Nov 13, 2019 •

edited by ghost

Loading

pep8speaks commented Nov 13, 2019 •

edited

Loading

wafels commented Nov 13, 2019

nabobalis commented Nov 16, 2019 •

edited

Loading

nabobalis commented Nov 16, 2019

nabobalis Nov 21, 2019

nabobalis Nov 21, 2019

Make Map work with WISPR Data #3501

Make Map work with WISPR Data #3501

Conversation

Cadair commented Nov 13, 2019 • edited Loading

ghost commented Nov 13, 2019 • edited by ghost Loading

pep8speaks commented Nov 13, 2019 • edited Loading

Comment last updated at 2019-11-21 21:52:08 UTC

wafels commented Nov 13, 2019

nabobalis commented Nov 16, 2019 • edited Loading

nabobalis commented Nov 16, 2019

nabobalis Nov 21, 2019

Choose a reason for hiding this comment

nabobalis Nov 21, 2019

Choose a reason for hiding this comment

Cadair commented Nov 13, 2019 •

edited

Loading

ghost commented Nov 13, 2019 •

edited by ghost

Loading

pep8speaks commented Nov 13, 2019 •

edited

Loading

nabobalis commented Nov 16, 2019 •

edited

Loading