Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix __repr__ for unknown coordinate systems #3569

Merged
merged 2 commits into from
Dec 15, 2019

Conversation

dstansby
Copy link
Member

Fixes #2452

@dstansby dstansby added the map Affects the map submodule label Nov 30, 2019
@ghost
Copy link

ghost commented Nov 30, 2019

Thanks for the pull request @dstansby! Everything looks great!

1 similar comment
@ghost
Copy link

ghost commented Nov 30, 2019

Thanks for the pull request @dstansby! Everything looks great!

@dstansby dstansby added this to the 1.1.1 milestone Dec 1, 2019
@wtbarnes
Copy link
Member

wtbarnes commented Dec 2, 2019

Out of curiosity, in what context do you have an unknown coordinate system?

@dstansby
Copy link
Member Author

dstansby commented Dec 2, 2019

@Cadair's original example was when 'CUNIT1' was 'STUART1', so maybe he invented his own coordinate system? I'm not sure to be honest, but I feel like if one can make an object without an error then __repr__ shouldn't raise an error.

@nabobalis nabobalis modified the milestones: 1.1.1, 1.0.7 Dec 15, 2019
@nabobalis nabobalis merged commit 27852da into sunpy:master Dec 15, 2019
@sunpy-backport
Copy link

The backport to 1.0 failed:

Commits ["3064b35e5562edd3c182d63cd242539c5451f4c8","932fc06717948815678c1135021c580e8a43c528"] could not be cherry-picked on top of 1.0

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub.
git fetch
# Create new working tree.
git worktree add .worktrees/backport 1.0
# Navigate to the new directory.
cd .worktrees/backport
# Cherry-pick all the commits of this pull request and resolve the likely conflicts.
git cherry-pick 3064b35e5562edd3c182d63cd242539c5451f4c8 932fc06717948815678c1135021c580e8a43c528
# Create a new branch with these backported commits.
git checkout -b backport-3569-to-1.0
# Push it to GitHub.
git push --set-upstream origin backport-3569-to-1.0
# Go back to the original working tree.
cd ../..
# Delete the working tree.
git worktree remove .worktrees/backport

Then, create a pull request where the base branch is 1.0 and the compare/head branch is backport-3569-to-1.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
map Affects the map submodule
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The repr of GenericMap raises an error if the WCS is an unknown type.
4 participants