Common API tools to get Sunrise bills only; display Sunrise bills only in Homepage #48
Conversation
There was a problem hiding this comment.
This doesn't handle filters atm, so it will break existing behavior. I don't think this should be merged as-is.
@agreffard mentioned that he intends to add that? Alternatively, I'm working on a change for the other branch to fix this.
|
I think @derekmiranda sad he will have a look. I think it's a matter of combining the 2 term values (one for the filters, one for the sunrse bill selection). Let me know if it's not that easy @derekmiranda we can try to find a moment for pair-programming |
|
@agreffard @elliott-king i committed a change to integrate the searchTerm w/ legislator name and bill status. tho i dont think it's quite filtering by those filters, the search term gets applied when i check the api requests |
There was a problem hiding this comment.
I'd be okay with just approving #40, approving this, merging both, and check to see they work.
I have my own fix locally, but it is a lot bigger and this does the trick afaik
frontend/src/api/requests.js
Outdated
| const term = encodeURIComponent( | ||
| `basePrintNo:(${page.map((printNo) => `+${printNo}`).join(' OR ')}) ${addedTerm}` | ||
| ); |
There was a problem hiding this comment.
| const term = encodeURIComponent( | |
| `basePrintNo:(${page.map((printNo) => `+${printNo}`).join(' OR ')}) ${addedTerm}` | |
| ); | |
| let term = `printNo:(${page.map((printNo) => `${printNo}`).join(' OR ')}) ${addedTerm}`; | |
| // term = encodeURIComponent(term); | |
| // console.log('term', term); |
- I'm having issues w/ HTML encoding (request only works w/out)
- why the plus in
+${basePrintNo}? - for some reason, I'm also getting versioned bill (this may be my fault, maybe we should use
printNoinstead ofbasePrintNo..?)
Otherwise, it seems to work to me.
There was a problem hiding this comment.
the plus was an attempt to get it working with the legislator and status filters; i thought that applying some more specificity with the print num would let those filters actually filter by legislator or status. i dont think it's doing anything so ill remove
i'll also use printNo instead of basePrintNo, if it adds more specificity. im guessing "versioned bills" means non-canonical versions of the main bill?
There was a problem hiding this comment.
I don't understand why this file is here.
There was a problem hiding this comment.
that shouldnt be there ill remove it
This PR is probably conflicting your work @derekmiranda ; this is a proposition, feel free to dismss it.
Or if you think this is going in the right direction we can discuss tomorrow how to integrate the filters work on it!