Refactoring to use more builtins (display-buffer) #21
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
Thanks for the package. When I started using it I noticed that the windows from the vterm buffers didn't respect the customizations that I wanted to put in
display-buffer-alist
, so I made a few changes. I don't know if you will want to merge them (there are a lot), and I didn't test completely the changes:pop-to-buffer
instead of manual window manipulations and switchdefcustom
to mimic parameters fromdisplay-buffer-alist
to control window positionsget-buffer
andget-buffer-window
--
convention for internal functionsmulti-vterm-get-buffer
to show that it creates a buffer on miss, just like the difference betweenget-buffer
andget-buffer-create
There are probably a few other changes. I set the PR as draft because I would like to test those changes on my setup for a few weeks before, but I'll take all feedback (even if it is "I won't merge it")