re-add optional argument #7
Conversation
|
This package is in the process of publishing on melpa. The others have concerned this arg. We don't use it internally in the package. So, I recommend that you to write your own function to add this arg on spacemacs. FYI: The package is renamed to |
|
Not sure I fully understand the issue. Re-adding the variable obviously has some effect, so it must not be totally unused in the package, even if it's not used in that function. I'm not sure why just re-adding the optional argument seems to restore the original behavior without having to modify anything else, but it would imply that it's used somewhere in some capacity. |
|
Can you please add docstring to explain why we need this unused arg? So that, everyone can understand how/where the arg is used. |
|
When the function argument is there and you pass in a string, it uses that as the name for the newly spawned terminal instead of the default naming. I'm not sure how it does this, since it's not obvious in the code, but it did do it before this was removed. I've been using my fork and it looks like this has changed more, I'll revisit it when I get a chance |
Fixes #6