Fix loading prop receiving a non-boolean value

supabase-community · Oct 28, 2022 · 8dd8fba · 8dd8fba
1 parent 3434dbb
commit 8dd8fba
Show file tree

Hide file tree

Showing 3 changed files with 15 additions and 2 deletions.
diff --git a/.changeset/chilly-jars-teach.md b/.changeset/chilly-jars-teach.md
@@ -0,0 +1,5 @@
+---
+'@supabase/auth-ui-react': patch
+---
+
+Fix warning about the loading receiving a non-boolean attribute
diff --git a/packages/react/src/components/Auth/interfaces/EmailAuth.tsx b/packages/react/src/components/Auth/interfaces/EmailAuth.tsx
@@ -147,7 +147,12 @@ function EmailAuth({
           </div>
         </Container>
 
-        <Button type="submit" color="primary" appearance={appearance}>
+        <Button
+          type="submit"
+          color="primary"
+          loading={loading}
+          appearance={appearance}
+        >
           {i18n?.[authView]?.button_label}
         </Button>
 

diff --git a/packages/react/src/components/UI/Button.tsx b/packages/react/src/components/UI/Button.tsx
@@ -54,6 +54,8 @@ const Button: React.FC<ButtonProps> = ({
   children,
   color = 'default',
   appearance,
+  icon,
+  loading = false,
   ...props
 }) => {
   const classNames = generateClassNames(
@@ -67,8 +69,9 @@ const Button: React.FC<ButtonProps> = ({
       {...props}
       style={appearance?.style?.button}
       className={classNames.join(' ')}
+      disabled={loading}
     >
-      {props.icon}
+      {icon}
       {children}
     </button>
   )