fix(chat): prevent Enter key action during IME composition #84
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
issue
What kind of change does this PR introduce?
Bug fix
What is the current behavior?
Currently, when typing in languages that use Input Method Editors (IMEs) such as Japanese, pressing the Enter key to confirm the IME conversion unintentionally sends the message. This occurs because the system doesn't distinguish between normal Enter key presses and those used for IME conversion confirmation.
What is the new behavior?
This PR adds an
isComposing
check to thekeydown
event handler. This prevents the message from being sent while the user is still in the process of IME composition. Here's a snippet of the modified code:This change ensures that the Enter key only sends the message when it's not being used for IME composition confirmation.
Additional context
This bug fix improves the user experience for those typing in languages that use IMEs, such as Japanese, Chinese, and Korean. It prevents accidental message sending during the composition process, allowing for a smoother typing experience in these languages.