Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support specifying npm registries via .npmrc #427

Merged
merged 15 commits into from
Oct 17, 2024

Conversation

nyannyacha
Copy link
Collaborator

@nyannyacha nyannyacha commented Oct 15, 2024

What kind of change does this PR introduce?

Feature

Description

Add support for importing packages from the private npm registry via .npmrc.

Also, the packages imported from these registries are added together during the bundling process, so it shouldn't change existing behavior.

Resolves #402

@nyannyacha nyannyacha marked this pull request as ready for review October 16, 2024 03:02
@elyobo
Copy link

elyobo commented Oct 16, 2024

Thanks @nyannyacha 🎉

@nyannyacha
Copy link
Collaborator Author

I apologize for the delay.😅 The other work is taking longer than I expected, so I decided to prioritize this.
Thanks for your patience!

@elyobo
Copy link

elyobo commented Oct 16, 2024

No need for apologies at all!

@nyannyacha nyannyacha merged commit 051a276 into supabase:main Oct 17, 2024
3 checks passed
@nyannyacha nyannyacha deleted the feat-enable-private-registry branch October 17, 2024 02:11
Copy link

🎉 This PR is included in version 1.59.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Private npm packages cannot be imported in edge functions: npm package '@org/package' does not exist.
3 participants