Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add stale bot #774

Merged
merged 1 commit into from
Apr 29, 2024
Merged

Add stale bot #774

merged 1 commit into from
Apr 29, 2024

Conversation

juancarlospaco
Copy link
Contributor

@juancarlospaco juancarlospaco commented Apr 17, 2024

What kind of change does this PR introduce?

  • Add stale bot to mark issues and PRs as Stale after a long period of inactivity.
  • Currently, it does NOT close issues automatically, but it can do so if wanted.

Additional context

@juancarlospaco juancarlospaco requested a review from a team as a code owner April 17, 2024 20:33
Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @juancarlospaco - I've reviewed your changes and they look great!

Here's what I looked at during the review
  • 🟡 General issues: 2 issues found
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Docstrings: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment to tell me if it was helpful.

- uses: actions/stale@v9
with:
days-before-pr-stale: 365
days-before-pr-close: -1
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

suggestion (code_refinement): Setting days-before-pr-close to -1 may need reevaluation.

Consider the implications of never automatically closing stale PRs. If this is intentional, it's fine; otherwise, setting a positive number might be more appropriate.

Suggested change
days-before-pr-close: -1
days-before-pr-close: 30

days-before-pr-stale: 365
days-before-pr-close: -1
days-before-issue-stale: 365
days-before-issue-close: -1
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

suggestion (code_refinement): Review the setting for days-before-issue-close.

Setting this to -1 means issues will never be closed automatically. Ensure this aligns with your project management strategies.

Suggested change
days-before-issue-close: -1
days-before-issue-close: 30

Copy link

codecov bot commented Apr 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 64.76%. Comparing base (819ba63) to head (98032c5).
Report is 39 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff             @@
##             main     #774       +/-   ##
===========================================
+ Coverage   43.97%   64.76%   +20.78%     
===========================================
  Files          13       13               
  Lines         332      315       -17     
===========================================
+ Hits          146      204       +58     
+ Misses        186      111       -75     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants