-
-
Notifications
You must be signed in to change notification settings - Fork 210
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add stale bot #774
Add stale bot #774
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @juancarlospaco - I've reviewed your changes and they look great!
Here's what I looked at during the review
- 🟡 General issues: 2 issues found
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Docstrings: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment to tell me if it was helpful.
- uses: actions/stale@v9 | ||
with: | ||
days-before-pr-stale: 365 | ||
days-before-pr-close: -1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
suggestion (code_refinement): Setting days-before-pr-close
to -1 may need reevaluation.
Consider the implications of never automatically closing stale PRs. If this is intentional, it's fine; otherwise, setting a positive number might be more appropriate.
days-before-pr-close: -1 | |
days-before-pr-close: 30 |
days-before-pr-stale: 365 | ||
days-before-pr-close: -1 | ||
days-before-issue-stale: 365 | ||
days-before-issue-close: -1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
suggestion (code_refinement): Review the setting for days-before-issue-close
.
Setting this to -1 means issues will never be closed automatically. Ensure this aligns with your project management strategies.
days-before-issue-close: -1 | |
days-before-issue-close: 30 |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #774 +/- ##
===========================================
+ Coverage 43.97% 64.76% +20.78%
===========================================
Files 13 13
Lines 332 315 -17
===========================================
+ Hits 146 204 +58
+ Misses 186 111 -75 ☔ View full report in Codecov by Sentry. |
What kind of change does this PR introduce?
Additional context