HttpServer: Remove all leading slashes of served files #26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously only one leading slash was removed. This would lead to problems with the following Qt calls if there was more than one slash in the URL. The path would not be relative to `m_ServeFilesDirectory` but would be treated as absolute, leading to an error message because `HttpServer` does not allow reading outside of `m_ServeFilesDirectory` (and rightfully so). Signed-off-by: Lennart Sauerbeck <lennart.sauerbeck@sevencs.com>
|
I didn't test this as that would require quite a big amount of work in my current project. Can you please have an extra careful look at this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously only one leading slash was removed. This would lead to problems
with the following Qt calls if there was more than one slash in the URL.
The path would not be relative to
m_ServeFilesDirectorybut would betreated as absolute, leading to an error message because
HttpServerdoes not allow reading outside of
m_ServeFilesDirectory(and rightfully so).
Signed-off-by: Lennart Sauerbeck lennart.sauerbeck@sevencs.com