Output ESM build, and make module tree-shakeable #202
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@supasate this is now rebased against master, and ready to be reviewed. |
|
LGTM! Thanks for your contribution! |
|
@supasate any chance of seeing this released to npm before the end of the year? |
|
@unindented Just released in v6.1.0 :). |
|
Awesome, thank you! |
pmarfany
added a commit
to lluistfc/connected-react-router
that referenced
this pull request
Apr 30, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #196 by doing the following:
"esm"env withmodules: false."module"and"sideEffects"entries inpackage.jsonto notify Webpack that this module is tree-shakeable.createAll, as it's a choke point that imports all the things, making it impossible for Webpack to three-shake anything."rewire"plugin to only get applied during tests, as it makes no sense for it to be in production builds.