Create selectors to retrieve search and hash #203
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brendonpagano
approved these changes
Dec 14, 2018
|
LGTM! @antgonzales, please rebase. There is a small change in a previous PR that made this lib tree-shakable. |
|
@supasate crap, I forgot to add Typescript support for these selectors. Let me push that up as well as the rebase. Thanks for the feedback! |
We can currently get the location and this action, this change adds the ability to retrieve the current search and hash.
Add getter types for: getAction getSearch getHash
|
Please add to src/immutable.js and src/seamless-immutable.js too. (It needs to be separated for tree-shakable.) |
|
Hi @antgonzales, are you still working on this? If not, I'll merge first and add support for immutable and seamless-immutable in another PR. |
|
@supasate sorry haven't had the time over the holidays. Go ahead and merge and I'll do a fast follow this weekend. |
|
I already added them to immutable and seamless-immutable in #221. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We can currently get the location and this action, this change adds the ability to retrieve the current search and hash.