-
Notifications
You must be signed in to change notification settings - Fork 593
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix an invalid type definition #253
Conversation
Caused by #248 |
Can we merge this? |
You can revert update and fix version until it's fixed |
index.d.ts
Outdated
@@ -61,7 +61,7 @@ declare module 'connected-react-router' { | |||
export function createMatchSelector< | |||
S extends RouterRootState, Params extends { [K in keyof Params]?: string } | |||
>(path: string): matchSelectorFn<S, Params>; | |||
export function onLocationChanged(location: Location, action: RouterActionType, isFirstRendering: boolean = false) | |||
export function onLocationChanged(location: Location, action: RouterActionType, isFirstRendering: boolean) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this should be marked as optional parameter isFirstRendering?: boolean
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes. It needs to be optional.
@cometkim Can you address the comment? Then, I'll merge and release a patch. |
Thanks, just addressed @goszczynskip 's comment |
LGTM! |
Released in 6.3.1. Thanks everyone! |
First of all, Thank you for maintaining an awesome library project :)
I've got this type error after bumping up dependency versions.