Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add isFirstRendering property to RouterState interface #276

Merged
merged 1 commit into from
Apr 14, 2019

Conversation

TetsuyaNegishi
Copy link
Contributor

@TetsuyaNegishi TetsuyaNegishi commented Mar 23, 2019

The RouterState interface does not have the isFirstRendering property.
This PR is for adding the isFirstRendering property to the RouterState interface.

@supasate
Copy link
Owner

supasate commented Apr 1, 2019

Router state in the reducer doesn't have isFirstRendering property. If you intend to to fix it for the payload of LocationChangeAction, it's better to change the RouterState type to a new type composing RouterState.

@TetsuyaNegishi
Copy link
Contributor Author

TetsuyaNegishi commented Apr 2, 2019

Thank you for your feedback!
I Fixed it👍

@supasate
Copy link
Owner

Thanks for your contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants