-
Notifications
You must be signed in to change notification settings - Fork 594
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add "omitRouter" option #421
Conversation
@supasate Anything I can do to help this along? |
Until this is merged, I have a fork of this package up at https://www.npmjs.com/package/@blackarctic/connected-react-router |
Bump |
@blackarctic. Sorry for delayed response. Is your higher-level Router a React Router? If no, it would be out of scope of this package that intends for using with React Router. If yes, I would like to understand a bit more why you can't use ConnectedRouter instead of that React Router. |
We are using Webpack 5 module federation. Thus the React Router is in the host application but each app is using its own Redux store with its own connected-react-router instance. |
That sounds good to me. Would you mind adding a comment telling the use case of this option? So, other people can understand its purpose. |
Sure. Preference on where? |
LGTM. Thanks for your contribution! |
This allows for the following configuration:
Currently, my team is running into this situation where
Router
is provided at a higher point in the architecture and we want to useconnected-react-router
with our Redux store, but we needconnected-react-router
to use theRouter
instance that is higher up the tree instead of providing its own.This option is added as opt-in only and should not affect any existing usage.