Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add children to typings to support removal of same in react 18 typings #569

Merged
merged 1 commit into from
Jul 11, 2022

Conversation

aesser
Copy link
Contributor

@aesser aesser commented May 11, 2022

Current typing definition will cause the following error when upgrading to React 18 typing definitions
Property 'children' does not exist on type 'IntrinsicAttributes & IntrinsicClassAttributes ...

This PR adds the children prop.

Ref: #565

See also SO answer as reference:
https://stackoverflow.com/questions/71788254/react-18-typescript-children-fc/71809927#71809927

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants