Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

As a user I want to have the Coming Up field active when I create a new story, add current time T + 45 minutes [SDBELGA-466] #366

Merged
merged 2 commits into from
Nov 19, 2021
Merged

As a user I want to have the Coming Up field active when I create a new story, add current time T + 45 minutes [SDBELGA-466] #366

merged 2 commits into from
Nov 19, 2021

Conversation

GyanP
Copy link
Contributor

@GyanP GyanP commented Nov 11, 2021

No description provided.

@GyanP
As a user I want to have the Coming Up field active when I create a n…
b94100f 
…ew story, add current time T + 45 minutes [SDBELGA-466]
@petrjasek petrjasek added this to the bel12 milestone Nov 12, 2021
@GyanP GyanP marked this pull request as ready for review November 15, 2021 10:08
@GyanP GyanP requested a review from petrjasek November 15, 2021 10:08
@petrjasek
Copy link
Member

I'm not sure if we should hardcode it here if we have it already configured via UI

@GyanP
Copy link
Contributor Author

GyanP commented Nov 16, 2021

I'm not sure if we should hardcode it here if we have it already configured via UI

actually, we have to set while creating new article current time + 45 mins that we have to set it there I think because in UI we will have the enable/disable the toggle for coming upfield in the template.

@petrjasek
Copy link
Member

yep in the template we set the toggle on, and then when we create the item I guess it should read the value from the field config, so imo it should be all handled via core without additional code

@GyanP
Copy link
Contributor Author

GyanP commented Nov 19, 2021 •
edited
Loading

Okay, I have done the changes in the core so revert old changes which are not require further.

@GyanP GyanP closed this Nov 19, 2021
@GyanP GyanP reopened this Nov 19, 2021
@GyanP
Copy link
Contributor Author

GyanP commented Nov 19, 2021

Revert old changes which are not required now, as we did changes in core superdesk/superdesk-core#2298

@GyanP GyanP merged commit 637853a into superdesk:develop Nov 19, 2021
@petrjasek petrjasek modified the milestones: bel12, bel11.1 Dec 20, 2021
petrjasek pushed a commit that referenced this pull request Dec 20, 2021
@GyanP @petrjasek
As a user I want to have the Coming Up field active when I create a n…
d538db3 
…ew story, add current time T + 45 minutes [SDBELGA-466] (#366)

* As a user I want to have the Coming Up field active when I create a new story, add current time T + 45 minutes [SDBELGA-466]

* Revert belga specific changes for
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@petrjasek petrjasek petrjasek approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
bel11.1
Development

Successfully merging this pull request may close these issues.
2 participants
@GyanP @petrjasek