Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

missing vocabulary message fix #4187

Merged
merged 2 commits into from
Jan 20, 2023
Merged

missing vocabulary message fix #4187

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1f2fcac
missing vocabulary message fix
tomaskikutis Jan 19, 2023
a676702
e2e fix
tomaskikutis Jan 19, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 0 additions & 4 deletions e2e/client/specs/users_spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,10 +47,6 @@ describe('users', () => {
element(by.css('.modal__dialog .btn--primary')).click();
browser.sleep(2000); // wait for reload

// close "missing categories" vocabulary warning
// most likely it appears because refreshing the page causes test data to disappear
element(by.css('.p-dialog-header-icons')).click();

const header = element(by.css('[ng-hide="currentRoute.topTemplateUrl"]'));

browser.wait(ECE.presenceOf(header), 1000);
Expand Down
2 changes: 1 addition & 1 deletion scripts/validate-instance-configuration.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ export function maybeDisplayInvalidInstanceConfigurationMessage() {
const issues: Array<React.ReactNode> = [];

ng.get('vocabularies').getAllActiveVocabularies().then((vocabularies) => {
const categoriesMissing = vocabularies.find(({_id}) => _id === 'categories') != null;
const categoriesMissing = vocabularies.find(({_id}) => _id === 'categories') == null;

if (categoriesMissing) {
issues.push(
Expand Down