Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pull quote improvements #4246

Merged
merged 6 commits into from
Jun 24, 2023
Merged

Pull quote improvements #4246

merged 6 commits into from
Jun 24, 2023

Conversation

thecalcc
Copy link
Contributor

@thecalcc thecalcc commented May 12, 2023 •
edited
Loading

SDESK-6515

@tomaskikutis tomaskikutis changed the title Draft Pull quote improvements May 18, 2023
@tomaskikutis tomaskikutis marked this pull request as draft May 18, 2023 15:16
@tomaskikutis
Copy link
Member

What is remaining to be done here?

@thecalcc
Copy link
Contributor Author

What is remaining to be done here?

Finishing the formatting options directive

@thecalcc thecalcc marked this pull request as ready for review June 21, 2023 15:10
@tomaskikutis
Copy link
Member

don't add any types; inline that function in react component

@thecalcc thecalcc merged commit a4eca1e into superdesk:develop Jun 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tomaskikutis tomaskikutis tomaskikutis approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@thecalcc @tomaskikutis