Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make translations load synchronously #4267

Merged
merged 4 commits into from
Jun 23, 2023
Merged

Make translations load synchronously #4267

merged 4 commits into from
Jun 23, 2023

Conversation

thecalcc
Copy link
Contributor

@thecalcc thecalcc commented Jun 19, 2023 •
edited
Loading

SDESK-6971

tomaskikutis
tomaskikutis reviewed Jun 21, 2023
View reviewed changes
webpack.config.js Outdated Show resolved Hide resolved
scripts/appConfig.ts Show resolved Hide resolved
scripts/globals.d.ts Show resolved Hide resolved
scripts/translations.js Outdated Show resolved Hide resolved
tomaskikutis
tomaskikutis approved these changes Jun 22, 2023
View reviewed changes
Copy link
Member

@tomaskikutis tomaskikutis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

all good, fix CI and merge it

@thecalcc thecalcc merged commit cc796e1 into superdesk:develop Jun 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tomaskikutis tomaskikutis tomaskikutis approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@thecalcc @tomaskikutis