Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Media upload drop downs UI issue #4329

Merged
merged 1 commit into from
Sep 20, 2023
Merged

Media upload drop downs UI issue #4329

merged 1 commit into from
Sep 20, 2023

Conversation

dzonidoo
Copy link
Collaborator

SDANSA-510

tomaskikutis
tomaskikutis approved these changes Sep 19, 2023
View reviewed changes
Copy link
Member

@tomaskikutis tomaskikutis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

check if you're not breaking it in other places where this component is used which might be using light theme

@dzonidoo
Copy link
Collaborator Author

I already checked

@tomaskikutis
Copy link
Member

all good then

@tomaskikutis
Copy link
Member

actually not, you need to fix CI :D

@tomaskikutis
Copy link
Member

or no, actualy you don't - it's already broken there - not caused by your PR

@dzonidoo
Copy link
Collaborator Author

so i can merge it? right?

@tomaskikutis
Copy link
Member

yep

@dzonidoo dzonidoo merged commit 6e1f60d into superdesk:hotfix/2.6.3 Sep 20, 2023
5 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tomaskikutis tomaskikutis tomaskikutis approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dzonidoo @tomaskikutis