Multiedit e2e tests #4464
Merged
Multiedit e2e tests #4464
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…' into playwright-tests
| import {restoreDatabaseSnapshot, s} from './utils'; | ||
|
|
||
| test.describe('Multiedit', async () => { | ||
| test('Can open article in multiedit', async ({page}) => { |
There was a problem hiding this comment.
There's no reason to test only opening. The main test should be opening 2 items(it is MULTI edit after all), changing a field, like headline, saving both, closing multi edit and seeing if changes persisted. If opening items in multi edit mode didn't work, the main test wouldn't pass either.
tomaskikutis
reviewed
Jul 2, 2024
| import {restoreDatabaseSnapshot, s} from './utils'; | ||
|
|
||
| test.describe('Multiedit', async () => { | ||
| test('Can edit articles in multiedit', async ({page}) => { |
Comment on lines
37
to
41
| await page.locator(s('multiedit-screen', 'multiedit-article=story 2')).hover(); | ||
| await page | ||
| .locator(s('multiedit-screen', 'multiedit-article=story 2')) | ||
| .getByRole('button', {name: 'save'}) | ||
| .click(); |
There was a problem hiding this comment.
could you create multi-edit helpers file and extract saving there?
tomaskikutis
approved these changes
Aug 1, 2024
tomaskikutis
added a commit
to tomaskikutis/superdesk-client-core
that referenced
this pull request
Aug 9, 2024
This reverts commit 8e04663.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SDESK-7164