Design a better way to trigger the full view mode in the authoring #4534
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| return ( | ||
| <Tooltip | ||
| text={this.props.isExpanded ? 'Revert Authoring' : 'Expand Authoring'} |
There was a problem hiding this comment.
use "full width mode" and "leave full width mode"; translate strings
| @@ -101,7 +101,10 @@ angular.module('superdesk.apps.authoring', [ | |||
| .directive('html5vfix', directive.Html5vfix) | |||
| .directive('sdDashboardCard', directive.DashboardCard) | |||
| .component('sdCharacterCount', reactToAngular1(CharacterCount, ['item', 'html', 'limit'], [], 'display: inline')) | |||
| .component('sdAuthoringIntegrationWrapper', reactToAngular1(AuthoringAngularIntegration, ['itemId', 'action'], [])) | |||
| .component('sdAuthoringIntegrationWrapper', reactToAngular1( | |||
| AuthoringAngularIntegration, ['itemId', 'action', 'hideMonitoring', 'isExpanded'], | |||
There was a problem hiding this comment.
Update terminology accross files so it's the following:
fullWidth / setFullWidth - for both authoring components
monitoringHidden / setMonitoringHidden - for monitoring
The reason for different names is to reduce coupling and limit information authoring receives about implementation details of the rest of the system.
| @@ -5,7 +5,7 @@ | |||
| sd-media-query min-width="880" | |||
| data-test-id="authoring-topbar" | |||
| > | |||
|
|
|||
| <toggle-full-width ng-click="hideMonitoring(currentRoute.href === item.href, $event)" ng-href="#{{ :: item.href }}" is-expanded="monitoringHidden"></toggle-full-width> | |||
There was a problem hiding this comment.
are arguments to hideMonitoring doing anything? When I logged them, it always appears empty
| import classNames from 'classnames'; | ||
| import {gettext} from 'core/utils'; | ||
|
|
||
| interface IProps { |
There was a problem hiding this comment.
props should be:
interface IProps {
fullWidth: boolean;
setFullWidth(): void;
}
tomaskikutis
approved these changes
Jun 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SDESK-7269