Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new 'getCustomVacabulary' function in superdesk-api [SDESK-7268] #4541

Merged
merged 5 commits into from
Jun 13, 2024

Conversation

devketanpro
Copy link
Member

Add new getCustomVacabulary func in superdesk-api which we used in supedesk-analytics.
superdesk/superdesk-analytics#151

@tomaskikutis
Copy link
Member

Do we have a clear definition of what exactly is a "custom" vocabulary? I'd rather expose a method to get all vocabularies from here

@devketanpro
Copy link
Member Author

devketanpro commented Jun 12, 2024

yep, custom vocabularies means which vocab we can add via metadata settings.
In the backend we fetch this type of vocab by query :- "field_type": None, "service": {"$exists": True}

@devketanpro devketanpro requested review from tomaskikutis and removed request for MarkLark86 June 13, 2024 08:15
@petrjasek petrjasek added this to the 2.8 milestone Jun 13, 2024
@tomaskikutis
Copy link
Member

Since I was looking at vocabulary code I also pushed some improvements.

Regarding your code, one improvement I made is to keep API slimmer is to only expose isCustomVocabulary method. I also exposed a method to get all vocabularies so you can later filter them using isCustomVocabulary.

Let me know if you have other improvements in mind.

@devketanpro devketanpro merged commit 61d411e into superdesk:develop Jun 13, 2024
3 checks passed
@devketanpro devketanpro deleted the SDESK-7268 branch June 13, 2024 11:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants