Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor all notifications from extensions and UI toggling such that … #4589

Merged
merged 13 commits into from
Aug 14, 2024

Conversation

thecalcc
Copy link
Contributor

@thecalcc thecalcc commented Aug 5, 2024

SDBELGA-818

  • Registered notifications are displayed with value true even if a user doesn't have them saved in preferences
  • Email notification group toggling works and does toggle all sub notifications no matter if they haven't been set before by the user, or if they have been
  • Saving works in both cases
  • Canceling works in both cases
  • Desktop notifications aren't shown in the notifications sidebar if a user has toggled them off
  • Email notifications aren't received if a user has toggled them off

scripts/core/superdesk-api.d.ts Outdated Show resolved Hide resolved
@@ -48,8 +48,7 @@ const extension: IExtension = {
},
notifications: {
'item:marked': {
type: 'desktop',
label: gettext('open item'),
name: gettext('Mark for User'),
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

does this unified notification notify both of marking and unmarking? Check with if API exposes this information and coordinate with Petr if not

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, works for marking and unmarking. Only difference between the two previously was the body message, handler was indeed the same one.

scripts/apps/users/directives/UserPreferencesDirective.ts Outdated Show resolved Hide resolved
scripts/apps/users/directives/UserPreferencesDirective.ts Outdated Show resolved Hide resolved
Copy link
Member

@tomaskikutis tomaskikutis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let's verify that unified notification works (mark/unmark) including enabling/disabling

@thecalcc thecalcc merged commit fffbc6c into superdesk:develop Aug 14, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants