send list of registered transmission services to client #1911
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
petrjasek
requested review from
a team and
ride90
and removed request for
a team
ride90
approved these changes
Jun 29, 2020
| @@ -35,6 +36,11 @@ | |||
| def register_transmitter(transmitter_type, transmitter, errors): | |||
| registered_transmitters[transmitter_type] = transmitter | |||
| transmitter_errors[transmitter_type] = dict(errors) | |||
| registered_transmitters_list.append({ | |||
| 'type': transmitter_type, | |||
| 'name': transmitter.NAME or transmitter_type, | |||
There was a problem hiding this comment.
I would use getattr(transmitter, 'NAME', transmitter_type) just in case NAME does not exist as attr.
My bad, I see that NAME always there.
petrjasek
added a commit
that referenced
this pull request
Jun 29, 2020
ride90
added a commit
to ride90/superdesk-core
that referenced
this pull request
Jul 1, 2020
* upstream/develop: Include all schema items in default search projection + archive_item (superdesk#1913) send list of registered transmission services to client (superdesk#1911) stop logging not queued error when testing (superdesk#1909) FIX: Missing texts/labels for macros in desk settings. [SDESK-5350] (superdesk#1912) Fixed Macros. (superdesk#1902)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SDCP-247