Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

As a user I want to have the Coming Up field active when I create a new story. [SDBELGA-466] #2298

Merged
merged 6 commits into from
Nov 24, 2021
Merged

As a user I want to have the Coming Up field active when I create a new story. [SDBELGA-466] #2298

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
1ba2f9f
As a user I want to have the Coming Up field active when I create a n…
GyanP Nov 19, 2021
58bc8c2
Address comments
GyanP Nov 19, 2021
4c39987
minor change
GyanP Nov 22, 2021
0a99a89
use kwargs in timedelta
GyanP Nov 22, 2021
441d168
Add test case
GyanP Nov 24, 2021
75692f7
minor change
GyanP Nov 24, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions apps/templates/filters.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,9 +63,9 @@ def first_paragraph_filter(input_string):
return ""


def add_timedelta(date, minutes):
def add_timedelta(date, **kwargs):
try:
return date + timedelta(minutes=minutes)
return date + timedelta(minutes=kwargs.get("minutes"))
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it should be rather timedelta(**kwargs) here so there can be hours/seconds/whatever

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yep, I will do the changes.

except Exception:
logger.warning("Failed to add minutes in Datetime - {}".format(date))

Expand Down