fix media expiry from mongo #2336
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
removing of expired media items didn't work as we were not using ObjectId but str. also remove media_references when deleting an item so those won't prevent published media from being removed. SDESK-6432
MarkLark86
reviewed
Apr 13, 2022
|
|
||
| for attachment in doc.get("attachments", []): | ||
| lookup = {"_id": attachment["attachment"]} | ||
| get_resource_service("attachments").delete_action(lookup) | ||
|
|
||
|
|
||
| def remove_media_references(item_id, published): | ||
| get_resource_service("media_references").delete_action({"item_id": item_id, "published": published}) |
There was a problem hiding this comment.
Would this need an index for published, or do you think this should be fast enough?
There was a problem hiding this comment.
there is item_id index and then it's only a few items to be checked so should be fine
MarkLark86
approved these changes
Apr 13, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
removing of expired media items didn't work
as we were not using ObjectId but str.
also remove media_references when deleting
an item so those won't prevent published
media from being removed.
SDESK-6432