fix(gmail) token expiry calculation is wrong #2381
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
might be because our servers are close to utc timezone (only +1 or +2) |
petrjasek
approved these changes
Sep 16, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm surprised no one else seems to have this problem!
We get a timestamp time from google and save it in expires_at as time zone naïve in the oauth2_token collection, using datetime.fromtimestamp with tz parameter so it returns local time naïve.
It is assumed by mongo to be UTC.
When we retrieve it in timezone UTC+10 the expires_at is effectively well in the future so don't refresh the token when required.
So now we just treat it as timezone naïve when testing if near expiry.