fix filter conditions with like/startswith/endswith #2408
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
use `regex.search` instead of `regex.match` which is not looking for the whole thing to match but it can match anywhere in the value. we're adding `.*` before and after the regex, but that doesn't work with filters like `Foo|Bar|Baz` as those `.*` are only applied to the begging and then `Bar` would only match if it's the only content in the field. SDESK-6755
MarkLark86
approved these changes
Dec 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
use
regex.searchinstead ofregex.matchwhich is not looking for the whole thing to match but it can match anywhere in the value.we're adding
.*before and after the regex, but that doesn't work with filters likeFoo|Bar|Bazas those.*are only applied to the begging and thenBarwould only match if it's the only content in the field.SDESK-6755