SDAAP-75 Add function to remove embedded media content #2459
Conversation
| if renditions: | ||
| for name, rendition in renditions.items(): | ||
| rendition["href"] = ( | ||
| self.path.lstrip("/") |
There was a problem hiding this comment.
Why remove the / prefix? It was there in the original implementation
There was a problem hiding this comment.
The idea is to make the paths relative rather than absolute on the FTP server
There was a problem hiding this comment.
@marwoodandrew An issue I have with the change to the FTP path, will this not require a change to the config after updating?
I understand your reasons, but we will have to make sure this is communicated as a breaking change when we update clients that use this formatter/transmitter, so that their configs are updated.
There was a problem hiding this comment.
I don't think anyone else is using ninjs ftp formatter, so as long as we add some notice we should be fine
marwoodandrew
force-pushed
the
SDAAP-75
branch
2 times, most recently
from
c1b7d50
to
147b08c
Compare
|
@petrjasek Would be good to get your review as well please |
No description provided.