avoid extra push notifications when editing desk members #2513
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- only updated visible stages for users added/removed from desk - don't push `resource:updated` notifications when there are no fields updated. SDANSA-526
MarkLark86
reviewed
Feb 8, 2024
apps/desks.py
Outdated
| @@ -294,8 +294,12 @@ def __send_notification(self, updates, desk): | |||
| desk=desk.get("name"), | |||
| ) | |||
| push_notification("activity", _dest=activity["recipients"]) | |||
| get_resource_service("users").update_stage_visibility_for_user(user) | |||
There was a problem hiding this comment.
I see get_resource_service("users") 4 times in this function, might be good to store the service locally use it thereafter.
MarkLark86
approved these changes
Feb 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resource:updatednotifications when there are no fields updated.SDANSA-526