Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

auto tagger #189

Merged
merged 34 commits into from
Feb 8, 2024
Merged

auto tagger #189

merged 34 commits into from
Feb 8, 2024

Conversation

tomaskikutis
Copy link
Member

@cpefatimaabdillahi
Copy link
Collaborator

Hi Tomas,

Thanks for creating the branch.

We will restore superdesk-client-core/scripts/extensions/auto-tagging-widget directory and remove the extension from superdesk-cp/client/index.js.

Thanks

@tomaskikutis
Copy link
Member Author

No need to restore anything in superdesk-client-core. I've closed the pull request in superdesk-client-core so no changes will be done by it. Do continue your work in auto-tagger branch of superdesk-cp repository (this one that is used by this pull request).

@tcp-bhargav
Copy link
Contributor

Hello. There were changes made to the back end code as well in superdesk-core repository. I cannot see those changes in this repository. Where can I expect those changes being made.

Namely there was a semaphore.py in textcheckers/ai and changes in the init.py file as well to be addressed.

https://github.com/canadianpress/superdesk-core/tree/master/superdesk/text_checkers/ai

@tomaskikutis
Copy link
Member Author

As I've mentioned in superdesk/superdesk-client-core#4409 (comment), after I moved front-end code here, 5 more commits were pushed. Those you'll have to move here manually. Most of those commits are one liners so it shouldn't take much effort.

@petrjasek advise how to move back-end files from superdesk-core to this PR.

@petrjasek
Copy link
Member

I've moved the files here, but couldn't run it locally so not sure it works. and it needs a core change I've made a PR for:
superdesk/superdesk-core#2510
fyi @cpefatimaabdillahi

tcp-bhargav and others added 8 commits January 25, 2024 12:35
Added init function.
Updated type and name to JIMI XML 2
Added Code that writes back to KMM.
- Add subject tag group
- Filter by subject scheme
- Add error log and error display
- Fix service name in sendFeedback
Added NinjsFormatter2 Which we want to use.
Added New Jimi Formatter
added code for updated Associations and the suggested name reference.
Reverted Name back to JIMI
Added Code to write IPTC qcodes in Tagger output.
Added Exception Handling and Bug Fixes
* fix linking to segment 1

it has version 0 and we were only checking 1+

CPCN-598

* avoid html conversion for transcripts

CPCN-607

* revert test change

* avoid any links in transcripts
@petrjasek petrjasek merged commit fd5ca6d into develop Feb 8, 2024
8 checks passed
@petrjasek petrjasek deleted the auto-tagger branch February 8, 2024 12:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants