-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Auto tagger release v2.2 #287
Conversation
Match package.json to superdesk repo
Remove test parser
Reference commit: superdesk@0cbf813
different article languages
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good, will make a PR with those client core changes
} | ||
<div | ||
className="auto-tagging-widget__autocomplete-item" | ||
aria-label={`Item name ${_item.name}`} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you could also translate those via gettext if needed:
aria-label={gettext('Item name {{name}}', {name: _item.name})}
Thanks @petrjasek , please let us know if you have any questions regarding the core changes that were requested. |
can you pls check that PR @cpefatimaabdillahi if I got it right? superdesk/superdesk-client-core#4599 |
Hi @petrjasek , the commits look fine however just an fyi, relevance and creator are not specific to AI subjects since even manually added tags/indexes will have both attributes with creator = "human" and a predetermined number for relevance. |
seems like you can do this ISubject change in the extension @cpefatimaabdillahi : |
Sounds good. Just added. @petrjasek |
interface ISubject { | ||
creator: string; | ||
relevance: number; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think you have to make them optional:
creator?: string;
relevance?: string;
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Implemented @petrjasek
can you add me write permissions to your fork? trying to fix the conflicts but it won't allow me to push there |
Just sent a request @petrjasek. Although I can just resolve the conflict as well. |
Hi @petrjasek,
As our last Pull Request had to be rolled back due to too many errors and insufficient time to troubleshoot between UAT and Production releases, we prepared this ahead of your next UAT release. Most of the changes are carried over from our previous PR, with an additional 3-4 items related to the NINJSV3 formatter.
The changes include:
Client:
fr_CA.po
filesafeSlugline
,safeHeadline
,safeHeadlineExtended
creator
(string) andrelevance
(number)aria-label
to HTML elementsServer:
format_relevance
insemaphore.py
semaphore.py
semaphore.py
Environment:
search_parent_url
with the new URLChanges needed from Source Fabric as these files are outside of the superdesk-cp scope:
scripts/core/superdesk-api.d.ts
file in https://github.com/superdesk/superdesk-client-core/blob/e7409f91a0851f4efce9bb44412ad350a4e01cb3/scripts/core/superdesk-api.d.ts#L3703 so that we can add relevance and creator toISubjects
. This allows tags added via search usinggetExistingTags
in https://github.com/canadianpress/superdesk-cp-2/blob/version20.11/client/extensions/auto-tagger/src/data-transformations.ts to return relevance and creator.