-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add option to disable onClose/onClick functionality #872
Add option to disable onClose/onClick functionality #872
Conversation
What's the purpose of the PR? What use-case are you handling? |
Handling the case when a widget is pinned. If it is, we should disable specific onClick handlers. In this case the handles responsible for closing are the ones I've modified in this PR. Besides that the style related changes are because once pinned, when you hover on the sidebar, no close button should be shown. |
|
Removing a button if it's not needed in not the way to go about it I think. We need it to be present in the UI & make it |
How about not disabling closing and if user has it pinned, but still wants to close it - it would unpin and close as expected? |
SDBELGA-847