Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: [TRST-1376] Create separate renovate configuration file #193

Merged
merged 3 commits into from
Oct 30, 2023

Conversation

timurhamitov
Copy link
Contributor

Renovate deprecated configs from npm. Created separate configuration file which we can link from the repos.

@codesandbox-ci
Copy link

codesandbox-ci bot commented Oct 30, 2023

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 85326ee:

Sandbox Source
Vanilla Configuration

@codecov
Copy link

codecov bot commented Oct 30, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (d5d4d7d) 96.89% compared to head (85326ee) 96.89%.
Report is 59 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #193   +/-   ##
=======================================
  Coverage   96.89%   96.89%           
=======================================
  Files          15       15           
  Lines        1191     1191           
  Branches       79       79           
=======================================
  Hits         1154     1154           
  Misses         37       37           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@timurhamitov Maybe we should name it more specific?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@doniyor2109 Couldn't find a better name. please help:)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@timurhamitov What is the purpose of this? Maybe this helps us to choose the name

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@doniyor2109 It's just the same configuration from package.json that we have. But renovate deprecated this approach. I'm trying to prepare for renovate to remove npm support at all.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@doniyor2109 We can call it default.json or superdispatch-renovate.json or somethin like that. But when we will extend from this config in other repos we will provide the full path. So we need to be aware of this.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lets call it default then

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@doniyor2109 renamed

Co-authored-by: Doniyor Aliyev <doniyor2109@gmail.com>
@timurhamitov timurhamitov merged commit e5fdb60 into master Oct 30, 2023
3 checks passed
@timurhamitov timurhamitov deleted the TRST-1376 branch October 30, 2023 08:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants