Support: Fixd UUID and prefix outputs string #2358
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jieguangzhou
force-pushed
the
feat/output-key
branch
2 times, most recently
from
d147d45 to
2065e82
Compare
jieguangzhou
force-pushed
the
feat/output-key
branch
from
2065e82 to
0191078
Compare
jieguangzhou
changed the title
jieguangzhou
force-pushed
the
feat/output-key
branch
from
0191078 to
8050b45
Compare
blythed
approved these changes
Jul 31, 2024
superduper/backends/ibis/query.py
Outdated
| @@ -378,7 +378,9 @@ def outputs(self, *predict_ids): | |||
| attr = getattr(query, self.primary_id) | |||
| for identifier in predict_ids: | |||
| identifier = ( | |||
| identifier if '_outputs' in identifier else f'_outputs__{identifier}' | |||
| identifier | |||
| if '_outputs' in identifier | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Related Issues
Checklist
make unit_testingandmake integration-testingsuccessfully?Additional Notes or Comments