Fix default encoding and add cleanup tools for ibis #2359
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jieguangzhou
approved these changes
Jul 31, 2024
blythed
force-pushed
the
fix/bytes-encoding-sqlvector
branch
from
cb75ede to
9dea2ca
Compare
jieguangzhou
requested changes
Jul 31, 2024
| raise NotImplementedError | ||
| for table in self.conn.list_tables(): | ||
| logging.info(f"Dropping table: {table}") | ||
| if '_outputs__' in table: |
There was a problem hiding this comment.
Please change this to table.startswith(CFG.output_prefix)
There was a problem hiding this comment.
Ah yes good point.
blythed
force-pushed
the
fix/bytes-encoding-sqlvector
branch
from
9dea2ca to
328c9dc
Compare
jieguangzhou
approved these changes
Jul 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Related Issues
Checklist
make unit_testingandmake integration-testingsuccessfully?Additional Notes or Comments