Add _execute_select and filter in the Query class. #2363
Conversation
jieguangzhou
force-pushed
the
feat/select-filter
branch
from
d9acb49 to
e1540bf
Compare
jieguangzhou
force-pushed
the
feat/select-filter
branch
5 times, most recently
from
d1d61bc to
8dcae9d
Compare
superduper/backends/base/query.py
Outdated
| :param args: The arguments to filter by. | ||
| :param kwargs: Additional keyword arguments. | ||
| """ | ||
| query = self if self.parts else self.select() |
There was a problem hiding this comment.
Make sure the flavour of single filter query should be the select
There was a problem hiding this comment.
This function will conflict with the ibis implementation of .filter
There was a problem hiding this comment.
self.select() implies select * from table right?
I
There was a problem hiding this comment.
We will find all the columns and fill in to the args.
And I removed this filter method in the base query class
| return self._get_chain_native_query(parent, self.parts, method) | ||
|
|
||
| def _get_chain_native_query(self, parent, parts, method='encode'): | ||
| try: | ||
| for part in parts: | ||
| if isinstance(part, str): | ||
| parent = getattr(parent, part) | ||
| continue | ||
| args = self._encode_or_unpack_args( | ||
| part[1], self.db, method=method, parent=parent | ||
| ) | ||
| kwargs = self._encode_or_unpack_args( | ||
| part[2], self.db, method=method, parent=parent | ||
| ) | ||
| parent = getattr(parent, part[0])(*args, **kwargs) | ||
| except Exception as e: | ||
| logging.error(f'Error in executing query, parts: {parts}') | ||
| raise e | ||
|
|
There was a problem hiding this comment.
Separating this method allows for easier future expansion of the query, enabling the query to flexibly construct the parts list without being tied to the expression.
In the future, all Query classes can be merged into one class, with Query only recording the expression and being independent the type of the database.
We can use Databackend to execute the Query
There was a problem hiding this comment.
Ok, yes this is a possible approach.
superduper/backends/ibis/query.py
Outdated
| @@ -437,26 +480,3 @@ def __call__(self, *args, **kwargs): | |||
| table = self.db.databackend.get_table_or_collection(self.table) | |||
| args = tuple(table.columns) | |||
| return super().__call__(*args, **kwargs) | |||
|
|
|||
There was a problem hiding this comment.
Remove unuse codes
| class MongoOutputs(MongoQuery): | ||
| """A query class for MongoDB outputs. |
There was a problem hiding this comment.
Use _execute_outputs to replace this class.
jieguangzhou
force-pushed
the
feat/select-filter
branch
from
8dcae9d to
0a46a52
Compare
| if not isinstance(item, slice): | ||
| return super().__getitem__(item) | ||
| raise TypeError('Query index must be a string or a slice') |
There was a problem hiding this comment.
The parent class does not define the getitem method.
jieguangzhou
changed the title
jieguangzhou
force-pushed
the
feat/select-filter
branch
from
0a46a52 to
caa1e57
Compare
jieguangzhou
force-pushed
the
feat/select-filter
branch
5 times, most recently
from
fb2544b to
95900fa
Compare
blythed
force-pushed
the
feat/select-filter
branch
from
95900fa to
07ab9d1
Compare
superduper/backends/mongodb/query.py
Outdated
|
|
||
| Use aggregate to implement the outputs query | ||
| """ | ||
| def _get_filter_confitions(self): |
jieguangzhou
force-pushed
the
feat/select-filter
branch
from
07ab9d1 to
0275d6b
Compare
jieguangzhou
force-pushed
the
feat/select-filter
branch
from
0275d6b to
e3ca89e
Compare
Description
Related Issues
Checklist
make unit_testingandmake integration-testingsuccessfully?Additional Notes or Comments