Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Superduper renaming superduper #2387

Merged
merged 14 commits into from
Aug 15, 2024
Merged

Superduper renaming superduper #2387

merged 14 commits into from
Aug 15, 2024

Conversation

fazlulkarimweb
Copy link
Collaborator

Description

Related Issues

Checklist

  • Is this code covered by new or existing unit tests or integration tests?
  • Did you run make unit_testing and make integration-testing successfully?
  • Do new classes, functions, methods and parameters all have docstrings?
  • Were existing docstrings updated, if necessary?
  • Was external documentation updated, if necessary?

Additional Notes or Comments

@fazlulkarimweb fazlulkarimweb requested a review from thgnw August 13, 2024 14:43
@fazlulkarimweb fazlulkarimweb marked this pull request as ready for review August 13, 2024 14:43
@@ -1,6 +1,6 @@
# Anthropic

`superduper` allows users to work with `anthropic` API models. The key integration is the integration
`Superduper` allows users to work with `anthropic` API models. The key integration is the integration
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No this is the package.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Noted. The package will be package. I will keep the superduper as it is where it mentions the package.

@@ -1,6 +1,6 @@
# Cohere

`superduper` allows users to work with `cohere` API models.
`Superduper` allows users to work with `cohere` API models.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the package.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Noted. The package will be package. I will keep the superduper as it is where it mentions the package.

@@ -1,6 +1,6 @@
# OpenAI

`superduper` allows users to work with `openai` API models.
`Superduper` allows users to work with `openai` API models.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Package.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay

Copy link
Collaborator

@blythed blythed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let us remove "superduper" and use "Superduper". But Superduper doesn't make any sense.

@fazlulkarimweb
Copy link
Collaborator Author

Let us remove "superduper" and use "Superduper". But Superduper doesn't make any sense.

Agreed. I will check all other instances again on this light.

@fazlulkarimweb fazlulkarimweb requested a review from blythed August 14, 2024 19:34
@blythed blythed merged commit 890d4ba into main Aug 15, 2024
@blythed blythed deleted the update/superduper/docs branch August 15, 2024 10:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants