Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix the issue where MongoDB did not create the output table. #2466

Merged
merged 4 commits into from
Sep 23, 2024
Merged

Fix the issue where MongoDB did not create the output table. #2466

merged 4 commits into from
Sep 23, 2024

Conversation

jieguangzhou
Copy link
Collaborator

Description

Related Issues

Checklist

  • Is this code covered by new or existing unit tests or integration tests?
  • Did you run make unit_testing and make integration-testing successfully?
  • Do new classes, functions, methods and parameters all have docstrings?
  • Were existing docstrings updated, if necessary?
  • Was external documentation updated, if necessary?

Additional Notes or Comments

@jieguangzhou jieguangzhou changed the title Fix the issue where MongoDB failed to create the output table Fix the issue where MongoDB did not create the output table. Sep 20, 2024
@jieguangzhou jieguangzhou force-pushed the feat/mongodb_output_table branch 2 times, most recently from cc18b59 to d2ee1a0 Compare September 20, 2024 08:20
@jieguangzhou jieguangzhou linked an issue Sep 20, 2024 that may be closed by this pull request
[PRE-RELEASE-0.4] [BUG] Output tables are not being created for MongoDB #2437
Closed
@jieguangzhou jieguangzhou force-pushed the feat/mongodb_output_table branch from e678937 to 1eb7827 Compare September 20, 2024 09:23
@jieguangzhou jieguangzhou force-pushed the feat/mongodb_output_table branch from 1eb7827 to 85e64b9 Compare September 20, 2024 12:44
kartik4949
kartik4949 approved these changes Sep 22, 2024
View reviewed changes
superduper/backends/base/query.py Outdated
r.pop(KEY_BUILDS)
r.pop(KEY_BLOBS)
r.pop(KEY_FILES)
r.pop("_schema")
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

KEY_SCHEMA

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@jieguangzhou jieguangzhou force-pushed the feat/mongodb_output_table branch from 85e64b9 to fe4fd63 Compare September 23, 2024 03:25
@jieguangzhou jieguangzhou force-pushed the feat/mongodb_output_table branch from fe4fd63 to 8478d49 Compare September 23, 2024 03:28
@jieguangzhou jieguangzhou merged commit 658a673 into superduper-io:main Sep 23, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kartik4949 kartik4949 kartik4949 approved these changes

@blythed blythed Awaiting requested review from blythed

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[PRE-RELEASE-0.4] [BUG] Output tables are not being created for MongoDB
2 participants
@jieguangzhou @kartik4949