Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated CONTRIBUTING.md #2471

Merged
merged 1 commit into from
Sep 26, 2024
Merged

Conversation

jieguangzhou
Copy link
Collaborator

Description

Related Issues

Checklist

  • Is this code covered by new or existing unit tests or integration tests?
  • Did you run make unit_testing and make integration-testing successfully?
  • Do new classes, functions, methods and parameters all have docstrings?
  • Were existing docstrings updated, if necessary?
  • Was external documentation updated, if necessary?

Additional Notes or Comments

@jieguangzhou jieguangzhou force-pushed the doc/contribute branch 2 times, most recently from fdbb747 to bc08703 Compare September 24, 2024 14:12
@jieguangzhou jieguangzhou marked this pull request as ready for review September 24, 2024 14:12
Copy link
Collaborator

@blythed blythed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a nice guide. Just a few additions and some English things. Thanks!

- Plugin name in `pyproject.toml`
- Package name `superduper_<PLUGIN_NAME>`
3. Write the code for the plugin
4. Create the tests directory `plugin_test/` and write the tests
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we say something about which version number to assign to the plugin and how the releases work?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I added a brief introduction to the CONTRIBUTING.md, but we need another page to introduce the versioning details.

CONTRIBUTING.md Outdated Show resolved Hide resolved
CONTRIBUTING.md Outdated
cd superduper-docs
```

### Updated the documentation
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updating the documentation

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

CONTRIBUTING.md Outdated
- Plugin documentation
- Template documentation

**Create or update a plugin documentation**
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"documentation for a plugin"

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

CONTRIBUTING.md Outdated

**Create or update a plugin documentation**

After we create or update a plugin, we need to update the documentation.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After you create ...

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

CONTRIBUTING.md Outdated
1. Update the `README.md` file in the plugin directory.
2. Copy the file to the `superduper-docs/content/plugins` directory and change the file name to `<PLUGIN_NAME>.md`.

**Create or update a template documentation**
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Creating of updating documentation for a template

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@jieguangzhou
Copy link
Collaborator Author

This is a nice guide. Just a few additions and some English things. Thanks!

Thanks, I’ve updated it. Could you please take another look?

@jieguangzhou jieguangzhou force-pushed the doc/contribute branch 2 times, most recently from 2070853 to e7eb3a2 Compare September 26, 2024 08:39
@jieguangzhou jieguangzhou merged commit f11dce1 into superduper-io:main Sep 26, 2024
@jieguangzhou jieguangzhou linked an issue Sep 26, 2024 that may be closed by this pull request
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[PRE-RELEASE-0.4] Update guide for contributors
2 participants