-
Notifications
You must be signed in to change notification settings - Fork 469
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated CONTRIBUTING.md #2471
Updated CONTRIBUTING.md #2471
Conversation
fdbb747
to
bc08703
Compare
bc08703
to
0a74599
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a nice guide. Just a few additions and some English things. Thanks!
- Plugin name in `pyproject.toml` | ||
- Package name `superduper_<PLUGIN_NAME>` | ||
3. Write the code for the plugin | ||
4. Create the tests directory `plugin_test/` and write the tests |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we say something about which version number to assign to the plugin and how the releases work?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, I added a brief introduction to the CONTRIBUTING.md, but we need another page to introduce the versioning details.
CONTRIBUTING.md
Outdated
cd superduper-docs | ||
``` | ||
|
||
### Updated the documentation |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updating the documentation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
CONTRIBUTING.md
Outdated
- Plugin documentation | ||
- Template documentation | ||
|
||
**Create or update a plugin documentation** |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"documentation for a plugin"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
CONTRIBUTING.md
Outdated
|
||
**Create or update a plugin documentation** | ||
|
||
After we create or update a plugin, we need to update the documentation. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
After you create ...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
CONTRIBUTING.md
Outdated
1. Update the `README.md` file in the plugin directory. | ||
2. Copy the file to the `superduper-docs/content/plugins` directory and change the file name to `<PLUGIN_NAME>.md`. | ||
|
||
**Create or update a template documentation** |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Creating of updating documentation for a template
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
0a74599
to
84ce7b9
Compare
Thanks, I’ve updated it. Could you please take another look? |
2070853
to
e7eb3a2
Compare
e7eb3a2
to
84fa256
Compare
Description
Related Issues
Checklist
make unit_testing
andmake integration-testing
successfully?Additional Notes or Comments