Fix/ibis/sql tablelength fallback #2559
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kartik4949
force-pushed
the
fix/ibis/sql-tablelength-fallback
branch
2 times, most recently
from
15100cb to
c06098e
Compare
kartik4949
force-pushed
the
fix/ibis/sql-tablelength-fallback
branch
from
c06098e to
9726276
Compare
kartik4949
force-pushed
the
fix/ibis/sql-tablelength-fallback
branch
from
9726276 to
e43d238
Compare
jieguangzhou
approved these changes
Oct 25, 2024
| @@ -640,14 +641,21 @@ def _deep_flat_decode(r, builds, getters: _Getters, db: t.Optional['Datalayer'] | |||
| return r | |||
|
|
|||
|
|
|||
| def _check_if_version(x): | |||
| if x.isnumeric(): | |||
| if int(x) < _VERSION_LIMIT: | |||
There was a problem hiding this comment.
sure, we can do it
blythed
approved these changes
Oct 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
fix #2561
Related Issues
Checklist
make unit_testingandmake integration-testingsuccessfully?Additional Notes or Comments