Add remote data object and standardize templates #2564
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
blythed
force-pushed
the
build_templates
branch
2 times, most recently
from
610102c to
d7c68e8
Compare
blythed
force-pushed
the
build_templates
branch
25 times, most recently
from
77d5678 to
a2d8ee2
Compare
blythed
requested review from
jieguangzhou
and removed request for
jieguangzhou
blythed
force-pushed
the
build_templates
branch
from
a2d8ee2 to
4aed4ac
Compare
superduper/components/template.py
Outdated
| @@ -46,18 +46,22 @@ def __post_init__(self, db, artifacts, substitutions): | |||
| ) | |||
| if self.template_variables is None: | |||
| self.template_variables = self.template.variables | |||
| if 'output_prefix' not in self.template_variables: | |||
There was a problem hiding this comment.
We need to remove output_prefix if it exists, right?
jieguangzhou
approved these changes
Oct 28, 2024
blythed
force-pushed
the
build_templates
branch
2 times, most recently
from
29860b5 to
8e57280
Compare
blythed
force-pushed
the
build_templates
branch
from
8e57280 to
8580a6c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Related Issues
Checklist
make unit_testingandmake integration-testingsuccessfully?Additional Notes or Comments