Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed decode function and table.data #2570

Merged
merged 1 commit into from
Oct 29, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -102,6 +102,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
- Fix the ordering and sequencing of jobs initiated on `db.apply`
- Fix rest routes with db injection and prefix.
- Fix cluster db setter.
- Fix decode function

## [0.3.0](https://github.com/superduper-io/superduper/compare/0.3.0...0.2.0]) (2024-Jun-21)

Expand Down
3 changes: 3 additions & 0 deletions superduper/backends/local/compute.py
Original file line number Diff line number Diff line change
Expand Up @@ -67,6 +67,9 @@ def submit(self, job: Job) -> str:
self.db.metadata.update_job(job.identifier, 'status', 'running')

try:
logging.debug(
f'Running job {job.job_id}: {component.identifier}.{job.method}'
)
method = getattr(component, job.method)
output = method(*args, **kwargs)
except Exception as e:
Expand Down
3 changes: 2 additions & 1 deletion superduper/backends/local/crontab.py
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
from superduper.backends.base.crontab import CrontabBackend


# TODO: implement this
class LocalCrontabBackend(CrontabBackend):
"""Local crontab backend."""

Expand All @@ -20,7 +21,7 @@ def list_components(self):

def list_uuids(self):
"""List UUIDs of components."""
raise NotImplementedError
return []

def drop(self):
"""Drop the crontab."""
Expand Down
2 changes: 1 addition & 1 deletion superduper/base/document.py
Original file line number Diff line number Diff line change
Expand Up @@ -569,7 +569,7 @@ def _get_leaf_from_cache(k, builds, getters, db: t.Optional['Datalayer'] = None)
for other in keys:
import re

matches = re.findall(f'.*\?\(({k}\..*)\)', other)
matches = re.findall(f'.*\?\(({k}\..*?)\)', other)
old_other = other[:]
if matches:
for match in matches:
Expand Down
3 changes: 2 additions & 1 deletion superduper/components/table.py
Original file line number Diff line number Diff line change
Expand Up @@ -69,4 +69,5 @@ def add_data(self):
data = self.data.data
else:
data = self.data
self.db[self.identifier].insert(data).execute()
if data:
self.db[self.identifier].insert(data).execute()
Loading