Fix inconsistencies in the behavior of getFrameNumber
#98
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Setting the start frame or anim frames of an animatible to 0 is not the
same as that variable not being set. If
startFrame == 0
andanimFrames == 307
, andgetFrameNumber()
returns 307 at the end ofan animation, then one can infer that starting at frame 100 would be
accomplished like so:
However, if that function were to be called with 307, the animation will
play from frame 307 to 614 (leading to unexpected results).
Additionally, if playing that entire animation from frame 100 to 307
results in
getFrameNumber()
returning 307 the moment the animationends, then it should continue returning 307, and not change to 207 30ms
later.