Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Update example app #12

Merged
merged 1 commit into from
Mar 23, 2023
Merged

chore: Update example app #12

merged 1 commit into from
Mar 23, 2023

Conversation

nkshah2
Copy link

@nkshah2 nkshah2 commented Mar 23, 2023

Bug

  • Related issues linked using fixes #number
  • Integration tests added
  • Errors have a helpful link attached, see contributing.md

Feature

  • Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR.
  • Related issues linked using fixes #number
  • e2e tests added
  • Documentation added
  • Telemetry added. In case of a feature if it's used or not.
  • Errors have a helpful link attached, see contributing.md

Documentation / Examples

  • Make sure the linting passes by running pnpm build && pnpm lint
  • The "examples guidelines" are followed from our contributing doc

@nkshah2 nkshah2 requested a review from rishabhpoddar March 23, 2023 11:22
@rishabhpoddar rishabhpoddar merged commit 9606372 into canary Mar 23, 2023
@rishabhpoddar rishabhpoddar deleted the example-app-update branch March 23, 2023 11:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rishabhpoddar rishabhpoddar rishabhpoddar approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nkshah2 @rishabhpoddar