Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Use dynamic sso provider logo #830

Merged
merged 12 commits into from
Jun 26, 2024
Merged

Conversation

ohansFavour
Copy link
Contributor

@ohansFavour ohansFavour commented Jun 19, 2024

Summary of change

This PR ensures that the correct SSO provider logo is displayed based on the name provided in the ThirdParty.BoxySAML.init method.

Test Plan

  • Manual test (Modified the example app)

Screenshot 2024-06-20 at 11 10 54

Screenshot 2024-06-20 at 11 03 24

Screenshot 2024-06-20 at 11 02 01

Documentation changes

(If relevant, please create a PR in our docs repo, or create a checklist here highlighting the necessary changes)

Checklist for important updates

  • Changelog has been updated
  • frontendDriverInterfaceSupported.json file has been updated (if needed)
  • Changes to the version if needed
    • In package.json
    • In package-lock.json
    • In lib/ts/version.ts
  • Had run npm run build-pretty
  • Had installed and ran the pre-commit hook
  • Issue this PR against the latest non released version branch.
    • To know which one it is, run find the latest released tag (git tag) in the format vX.Y.Z, and then find the latest branch (git branch --all) whose X.Y is greater than the latest released tag.
    • If no such branch exists, then create one from the latest released branch.
  • If added a new recipe interface, then make sure that the implementation of it uses NON arrow functions only (like someFunc: function () {..}).
  • If I added a new recipe, I also added the recipe entry point into the size-limit section of package.json with the size limit set to the current size rounded up.
  • If I added a new recipe, I also added the recipe entry point into the rollup.config.mjs
  • If I added a new login method, I modified the list in lib/ts/types.ts
  • If I added a factor id, I modified the list in lib/ts/recipe/multifactorauth/types.ts

Remaining TODOs for this PR

  • Item1
  • Item2

Copy link

github-actions bot commented Jun 19, 2024

size-limit report 📦

Path Size
lib/build/index.js 22.48 KB (0%)
recipe/session/index.js 23.23 KB (0%)
recipe/session/prebuiltui.js 27.77 KB (0%)
recipe/thirdparty/index.js 31.33 KB (+12.88% 🔺)
recipe/emailpassword/index.js 11.07 KB (0%)
recipe/emailverification/index.js 7.84 KB (0%)
recipe/passwordless/index.js 14.76 KB (0%)
recipe/emailverification/prebuiltui.js 32.46 KB (0%)
recipe/thirdparty/prebuiltui.js 50.99 KB (+6.98% 🔺)
recipe/emailpassword/prebuiltui.js 38.54 KB (0%)
recipe/passwordless/prebuiltui.js 125.88 KB (0%)
recipe/multitenancy/index.js 6.67 KB (0%)
recipe/multifactorauth/index.js 10.77 KB (0%)
recipe/multifactorauth/prebuiltui.js 31.31 KB (0%)

@ohansFavour ohansFavour marked this pull request as draft June 19, 2024 17:17
@ohansFavour ohansFavour marked this pull request as ready for review June 21, 2024 00:23
@ohansFavour ohansFavour changed the base branch from master to 0.42 June 21, 2024 08:14
@ohansFavour ohansFavour changed the base branch from 0.42 to 0.43 June 21, 2024 08:31
@ohansFavour ohansFavour changed the base branch from 0.43 to 0.42 June 21, 2024 11:28
package.json Outdated Show resolved Hide resolved
@ohansFavour ohansFavour changed the base branch from 0.42 to 0.43 June 25, 2024 10:20
@ohansFavour ohansFavour force-pushed the fix/dynamic-sso-provider-logo branch 2 times, most recently from 48f5fab to f43dd39 Compare June 25, 2024 10:55
@ohansFavour ohansFavour force-pushed the fix/dynamic-sso-provider-logo branch from f43dd39 to bd7494f Compare June 25, 2024 11:07
@ohansFavour ohansFavour changed the title fix: Use dynamic sso provider logo feat: Use dynamic sso provider logo Jun 25, 2024
@porcellus porcellus merged commit ff2e671 into 0.43 Jun 26, 2024
27 of 30 checks passed
@porcellus porcellus deleted the fix/dynamic-sso-provider-logo branch June 26, 2024 21:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants